Update codex to 0.118.0 - #83
Merged
Merged
Conversation
Collaborator
|
Previous code:
Problem:
|
NikolaiSviridov
requested review from
AlexandrSuhinin and
dtim
and removed request for
dtim
April 1, 2026 14:52
AlexandrSuhinin
left a comment
AlexandrSuhinin
left a comment
Collaborator
There was a problem hiding this comment.
The change is quite big, I rather expect minimal patch to fix typecheck and tests.
AlexandrSuhinin
requested review from
AlexandrSuhinin
and removed request for
dtim
April 3, 2026 08:39
AlexandrSuhinin
previously requested changes
Apr 3, 2026
NikolaiSviridov
force-pushed
the
codex-update/0.118.0
branch
from
April 3, 2026 12:56
91c7690 to
0ed45c9
Compare
slapoguzov
approved these changes
Apr 7, 2026
NikolaiSviridov
dismissed
AlexandrSuhinin’s stale review
April 7, 2026 17:09
@slapoguzov approved MR after changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Previously failed tests and failure reasons:
src/__tests__/CodexACPAgent/CodexAcpClient.test.ts:should authenticate with keytimed out (40s).should authenticate with a gatewaytimed out (40s).src/__tests__/CodexACPAgent/mcp-session.test.ts:should return configured mcptimed out (40s).src/__tests__/CodexACPAgent/command-action-events.test.ts,src/__tests__/CodexACPAgent/terminal-output-events.test.ts, andsrc/__tests__/CodexACPAgent/load-session.test.tsfailed because updatedThreadItemnow requirescommandExecution.sourceandagentMessage.memoryCitation.src/__tests__/CodexACPAgent/fuzzy-file-search-events.test.tsfailed becauseFuzzyFileSearchResultnow requiresmatch_type.src/CodexAcpServer.tsandsrc/CodexEventHandler.tsfailed typecheck due non-exhaustiveswitchhandling after new protocol variants/events were added.What I changed and why:
switchhandling for new protocol variants so unions are exhaustively handled and no event/item variant is silently dropped:source: "agent"tocommandExecutionfixtures in command-action-events.test.ts and terminal-output-events.test.ts.memoryCitation: nullandsource: "agent"in load-session.test.ts.match_type: "file"in fuzzy-file-search-events.test.ts.